Skip to content

[Tooling] Run Danger on the Linter Agent #11504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented May 13, 2024

This PR uses the new Linter Agent on Buildkite to run the Danger jobs.

Because Danger will now run on Buildkite, this PR uses a new GitHub Actions workflow (see Automattic/dangermattic#64 for more details) to retry the Buildkite jobs when the PR state (such as the milestone and labels) changes.

@iangmaia iangmaia added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label May 13, 2024
@iangmaia iangmaia requested a review from mokagio May 13, 2024 19:25
@iangmaia iangmaia self-assigned this May 13, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 13, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commita48cf7b
Direct Downloadwoocommerce-prototype-build-pr11504-a48cf7b.apk

@iangmaia iangmaia added this to the 18.7 milestone May 14, 2024
@kidinov kidinov modified the milestones: 18.7, 18.8 May 17, 2024
@mokagio
Copy link
Contributor

mokagio commented May 20, 2024

Toggling the "tooling" label to see the GitHub Action - Buildkite - GitHub comment integration at play.

@mokagio mokagio modified the milestone: 18.8 May 20, 2024
@iangmaia iangmaia force-pushed the iangmaia/linter-agent branch from cf7200c to 5c3e352 Compare May 21, 2024 11:06
@iangmaia iangmaia force-pushed the iangmaia/linter-agent branch from 2490d1b to a48cf7b Compare May 21, 2024 11:55
@iangmaia iangmaia enabled auto-merge May 21, 2024 11:56
@iangmaia
Copy link
Contributor Author

@mokagio did it work? 🙂

@backwardstruck backwardstruck modified the milestones: 18.8, 18.9 May 24, 2024
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why I didn't approve this at the time of first looking at it. But I'd say it had to do with having too many tabs open rather than the code here.

:shipit:

@iangmaia iangmaia merged commit 50cd183 into trunk May 29, 2024
15 of 16 checks passed
@iangmaia iangmaia deleted the iangmaia/linter-agent branch May 29, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants